Skip to content

Arm backend: Make quantized where.self fuseable #15520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2025
Merged

Arm backend: Make quantized where.self fuseable #15520

merged 3 commits into from
Nov 4, 2025

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Nov 3, 2025 •
edited by pytorch-bot bot
Loading

Makes where.self fuseable and changes how where.self is annotated.

cc @freddan80 @per @zingo @digantdesai

@oscarandersson8218
Arm backend: Update where.self annotation
f632ea5 
where.self relied on node.args[1] being annotated. If this wasn't the
case a KeyError would be thrown. This patch looks if node.args[1] is
annotated.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I65d95e43dc8f4a2f2ee324d364a225f9b6e24b9d
@oscarandersson8218
Arm backend: Make quantized where.self fuseable
333fc6d 
where.self was previously not fuseable when quantized since its first
argument does not contain any quantization parameters.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Idff604cc3d2e5db05f35cd30eb53958b83045f4b
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15520

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Cancelled Job, 6 Unrelated Failures

As of commit 7f8e23d with merge base bde6b11 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Nov 3, 2025
@zingo zingo merged commit 96189bf into pytorch:main Nov 4, 2025
287 of 295 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oscarandersson8218 @zingo